-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #27994: compat.as_bytes should support bytearray #27995
Fix #27994: compat.as_bytes should support bytearray #27995
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@erwa please sign CLA |
I'm speaking with my legal team and just need to figure out a few details before signing the CLA. Hope to get back to you later this week. |
9cfa9d8
to
ec98e0c
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
ec98e0c
to
6dce393
Compare
@rthadur , I've signed the CLA. Could you help review the patch? |
Thanks for the review, @mihaimaruseac. I took a look at some of the failed CI builds and the failures look unrelated. Can you merge this PR? |
There's some infrastructure changes going on at the moment. Will merge when resolved. |
Thanks, Mihai. |
Can you solve conflict? |
6dce393
to
2e62302
Compare
Rebased on |
PiperOrigin-RevId: 245139769
I made these changes manually in a local venv and was then able to write to a GFile handle from a fastavro Writer, which writes out
bytearray
s.