Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #27994: compat.as_bytes should support bytearray #27995

Merged

Conversation

erwa
Copy link

@erwa erwa commented Apr 19, 2019

I made these changes manually in a local venv and was then able to write to a GFile handle from a fastavro Writer, which writes out bytearrays.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Apr 19, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 20, 2019
@rthadur rthadur self-assigned this Apr 20, 2019
@rthadur
Copy link
Contributor

rthadur commented Apr 20, 2019

@erwa please sign CLA

@erwa
Copy link
Author

erwa commented Apr 22, 2019

I'm speaking with my legal team and just need to figure out a few details before signing the CLA. Hope to get back to you later this week.

@rthadur rthadur added the stat:awaiting response Status - Awaiting response from author label Apr 22, 2019
@erwa erwa force-pushed the compat.as_bytes-bytearray-support branch from 9cfa9d8 to ec98e0c Compare April 23, 2019 17:40
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@erwa
Copy link
Author

erwa commented Apr 23, 2019

@googlebot I signed it!

@erwa erwa force-pushed the compat.as_bytes-bytearray-support branch from ec98e0c to 6dce393 Compare April 23, 2019 17:47
@erwa
Copy link
Author

erwa commented Apr 23, 2019

@rthadur , I've signed the CLA. Could you help review the patch?

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 23, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 23, 2019
mihaimaruseac
mihaimaruseac previously approved these changes Apr 23, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 23, 2019
@erwa
Copy link
Author

erwa commented Apr 23, 2019

Thanks for the review, @mihaimaruseac. I took a look at some of the failed CI builds and the failures look unrelated. Can you merge this PR?

@mihaimaruseac
Copy link
Collaborator

There's some infrastructure changes going on at the moment. Will merge when resolved.

@erwa
Copy link
Author

erwa commented Apr 23, 2019

Thanks, Mihai.

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Apr 24, 2019
@mihaimaruseac
Copy link
Collaborator

Can you solve conflict?

@rthadur rthadur added the stat:awaiting response Status - Awaiting response from author label Apr 24, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Apr 24, 2019
@erwa
Copy link
Author

erwa commented Apr 24, 2019

Rebased on master and resolved conflicts.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Apr 24, 2019
@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Apr 24, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 24, 2019
@tensorflow-copybara tensorflow-copybara merged commit 2e62302 into tensorflow:master Apr 24, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 24, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small stat:awaiting response Status - Awaiting response from author
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants